Add ansible linter test

.github/actions/run-sanity-tests/action.yaml → .github/actions/run-sanity-and-linter-tests/action.yaml

@@ -12,8 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-name: run-sanity-tests
-description: "Runs sanity tests"
+name: run-sanity-and-linter-tests
+description: "Runs sanity and linter tests"
 
 runs:
   using: composite
@@ -25,3 +25,7 @@ runs:
     - name: "Run sanity test"
       shell: bash
       run: pushd ~/.ansible/collections/ansible_collections/dynatrace/oneagent && ansible-test sanity && popd
+
+    - name: "Run linter test"
+      shell: bash
+      run: pushd ~/.ansible/collections/ansible_collections/dynatrace/oneagent && ansible-lint && popd

.github/actions/setup-build-environment/action.yaml

@@ -23,4 +23,4 @@ runs:
         python-version: '3.10'
     - name: "Install dependencies"
       shell: bash
-      run: pip install ansible
+      run: pip install ansible ansible-lint

.github/workflows/build-and-test.yaml

@@ -30,6 +30,6 @@ jobs:
       - name: Build the collection
         uses: ./.github/actions/build-collection
       - name: Run sanity tests
-        uses: ./.github/actions/run-sanity-tests
+        uses: ./.github/actions/run-sanity-and-linter-tests
       - name: Run component tests
         uses: ./.github/actions/run-component-tests

.github/workflows/build-test-and-publish.yaml

@@ -16,7 +16,7 @@
 on:
   push:
     tags:
       - "v*.*.*" 
 
 jobs:
   build-test-and-publish:
@@ -34,7 +34,7 @@
       - name: Build the collection
         uses: ./.github/actions/build-collection
       - name: Run sanity tests
-        uses: ./.github/actions/run-sanity-tests
+        uses: ./.github/actions/run-sanity-and-linter-tests
       - name: Run component tests
         uses: ./.github/actions/run-component-tests
       - name: Publish to Ansible Galaxy

.github/workflows/build-test-and-upload.yaml

@@ -15,7 +15,7 @@
 name: "Build, test and upload"
 on:
   push:
     branches: [ "master" ]
   workflow_dispatch:
 
 jobs:
@@ -30,7 +30,7 @@
       - name: Build the collection
         uses: ./.github/actions/build-collection
       - name: Run sanity tests
-        uses: ./.github/actions/run-sanity-tests
+        uses: ./.github/actions/run-sanity-and-linter-tests
       - name: Run component tests
         uses: ./.github/actions/run-component-tests
       - name: Upload the collection

roles/oneagent/examples/advanced_config/advanced_config.yml

@@ -3,8 +3,6 @@
     Download OneAgent installer in specific version to a custom directory with additional OneAgent install parameters.
     Both linux_other and linux_arm have different user specified by platform args parameter.
   hosts: linux_other,linux_arm
-  collections:
-    - dynatrace.oneagent
   # credentials.yml file contains oneagent_environment_url and
   # oneagent_paas_token variables that needs to be stored securely
   vars_files:
@@ -22,4 +20,4 @@
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent

roles/oneagent/examples/local_installer/local_installer.yml

@@ -3,9 +3,7 @@
     Basic OneAgent installation using a local installer. Hosts placed in unix hosts groups have its local installer paths defined in inventory file.
     Main node communicates with Windows hosts over SSH.
   hosts: windows,unix
-  collections:
-    - dynatrace.oneagent
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent

roles/oneagent/examples/oneagentctl_config/oneagentctl_config.yml

@@ -1,8 +1,6 @@
 ---
 - name: Apply host level configuration with oneagentctl
   hosts: linux_other
-  collections:
-    - dynatrace.oneagent
   vars:
     oneagent_install_args:
       - --set-host-name=new_host_name
@@ -12,4 +10,4 @@
   tasks:
     - name: Import Dynatrace OneAgent role
       ansible.builtin.import_role:
-        name: oneagent
+        name: dynatrace.oneagent.oneagent