Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warnings for missing Kubernetes-monitoring and custom image without CSI driver #4457

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

StefanHauth
Copy link
Collaborator

Description

Cherry-pick of #4449

How can this be tested?

See #4449

JIRA #1
JIRA #2
JIRA #3
JIRA #4

@StefanHauth StefanHauth added the cherrypick Cherrypicked changes that already exist in a different PR label Feb 12, 2025
@StefanHauth StefanHauth requested a review from a team as a code owner February 12, 2025 12:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (73fb339) to head (3a123a5).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4457   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files         413      413           
  Lines       27248    27253    +5     
=======================================
+ Hits        17687    17692    +5     
  Misses       8233     8233           
  Partials     1328     1328           
Flag Coverage Δ
unittests 64.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0sewa0 0sewa0 enabled auto-merge (squash) February 17, 2025 09:16
@0sewa0 0sewa0 merged commit 12ef55b into main Feb 17, 2025
14 checks passed
@0sewa0 0sewa0 deleted the improve-validation-warnings branch February 17, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick Cherrypicked changes that already exist in a different PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants