Fixes marbl column fields initialization #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed parm_f_prod_sp_CaCO3 from 0.07 to 0.049
Author
|
@jonbob : I'm not sure if this is the correct branch for merging. Should we create an E3SMv3? |
Author
|
@maltrud and @katsmith133 : This is the version I've tested to make sure it's bfb. I can also pull the code changes into a new initialization subroutine like we discussed. Let me know if I should proceed with that option. |
|
@njeffery -- I think this is right. We do this first in order to get a new hash for marbl, and then make an E3SM PR to move to the new hash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some column fields are never initialized in MARBL and only defined in active cells. This causes a crash when debug_build is true due to NaNs. This fix passes a debug compile = true.
See Issue E3SM-Project/E3SM#7990
The intialization is BFB after 2-years - see https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5866095251/01152026.v3.LR.GMPAS.marbl.compy
I've also changed a bgc parameter that's hardcoded. E3SMv3 HES is using parm_f_prod_sp_CaCO3 = 0.049_r8 instead of 0.07 to improve surface alkalinity. The change has been tested in several 100-year simulations including our emissions runs.
For example:
https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5184651334/20250306.v3.LR.HES-CBGC.20tr.Emissions01
nonBFB in BGC runs. BFB for all others.