Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --no_viewer option breaking #943

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Fix --no_viewer option breaking #943

merged 5 commits into from
Feb 18, 2025

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Feb 18, 2025

Description

2025-02-18 16:39:47,976 [INFO]: e3sm_diags_driver.py(_log_diagnostic_run_info:523) >> 
================================================================================
E3SM Diagnostics Run
--------------------
Timestamp: 2025-02-18 16:39:47
Version Info: branch bug/942-no-viewer with commit eb1a96e683bdab67d9bd420f4dadf2591d451c98
Results Path: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer
Log Path: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/prov/e3sm_diags_run.log
Parameter Files Path: N/A (No viewer generated)
Python Script Path: N/A (No viewer generated)
Environment YML Path: N/A (No viewer generated)
Provenance Index HTML Path: N/A (No viewer generated)
================================================================================

2025-02-18 16:39:52,525 [INFO]: lat_lon_driver.py(run_diag:69) >> Variable: TREFHT
2025-02-18 16:39:54,208 [INFO]: dataset_xr.py(_get_dataset_with_derived_climo_var:713) >> Deriving the test climatology variable using the source variables: ('TREFHT',)
2025-02-18 16:39:54,676 [INFO]: dataset_xr.py(_get_dataset_with_derived_climo_var:713) >> Deriving the ref climatology variable using the source variables: ('tas',)
2025-02-18 16:39:56,547 [INFO]: regrid.py(subset_and_align_datasets:70) >> Selected region: land
2025-02-18 16:40:45,476 [INFO]: io.py(_write_to_netcdf:151) >> 'TREFHT' test variable output saved in: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/lat_lon/ERA5/ERA5-TREFHT-ANN-land_test.nc
2025-02-18 16:40:45,482 [INFO]: io.py(_write_to_netcdf:151) >> 'TREFHT' ref variable output saved in: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/lat_lon/ERA5/ERA5-TREFHT-ANN-land_ref.nc
2025-02-18 16:40:45,487 [INFO]: io.py(_write_to_netcdf:151) >> 'TREFHT' diff variable output saved in: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/lat_lon/ERA5/ERA5-TREFHT-ANN-land_diff.nc
2025-02-18 16:40:45,489 [INFO]: io.py(_save_data_metrics_and_plots:77) >> Metrics saved in /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/lat_lon/ERA5/ERA5-TREFHT-ANN-land.json
2025-02-18 16:40:45,536 [WARNING]: warnings.py(_showwarnmsg:112) >> /home/ac.tvo/miniforge3/envs/e3sm_diags_dev_930/lib/python3.12/site-packages/cartopy/mpl/geoaxes.py:856: UserWarning: Attempting to set identical low and high xlims makes transformation singular; automatically expanding.
  self.set_xlim([x1, x2])

2025-02-18 16:40:46,049 [WARNING]: warnings.py(_showwarnmsg:112) >> /home/ac.tvo/miniforge3/envs/e3sm_diags_dev_930/lib/python3.12/site-packages/cartopy/mpl/geoaxes.py:856: UserWarning: Attempting to set identical low and high xlims makes transformation singular; automatically expanding.
  self.set_xlim([x1, x2])

2025-02-18 16:40:48,733 [WARNING]: warnings.py(_showwarnmsg:112) >> /home/ac.tvo/miniforge3/envs/e3sm_diags_dev_930/lib/python3.12/site-packages/cartopy/mpl/geoaxes.py:856: UserWarning: Attempting to set identical low and high xlims makes transformation singular; automatically expanding.
  self.set_xlim([x1, x2])

2025-02-18 16:40:53,335 [INFO]: utils.py(_save_plot:92) >> Plot saved in: /lcrc/group/e3sm/public_html/cdat-migration-fy24/942-no-viewer/lat_lon/ERA5/ERA5-TREFHT-ANN-land.png
2025-02-18 16:40:53,412 [INFO]: e3sm_diags_driver.py(main:438) >> Viewer not created because the no_viewer parameter is True.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Related to `prov_paths` variable not being set with attempting to print out diagnostic run information
@tomvothecoder tomvothecoder self-assigned this Feb 18, 2025
@tomvothecoder tomvothecoder merged commit e2fcc3a into main Feb 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error with --no-viewer argument in rc3.0.0.rc3
1 participant