Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inertial gravity wave test #267

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 24, 2025

The viz step didn't get updated when we added refinement in just space and just time separately, so that is the main fix here. The viz step is now more similar to the manufactured solution step, which was fixed in #250.

This merge also sets the namelist option config_disable_tr_all_tend = .true., which was correctly dropped from the single_layer.yaml in #262 but which now is correctly included in this test's forward.yaml.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

xylar added 2 commits January 24, 2025 06:07
This step didn't get updated when we added refinement in just
space and just time separately
This was being turned off elsewhere until E3SM-Project#262 for single-layer
tests (which this one is by default) but should be turned off
by default.
@xylar xylar added bug Something isn't working ocean Related to ocean tests or analysis labels Jan 24, 2025
@xylar xylar requested a review from cbegeman January 24, 2025 13:58
@xylar xylar self-assigned this Jan 24, 2025
@xylar
Copy link
Collaborator Author

xylar commented Jan 24, 2025

Testing

I ran all three inertial gravity wave tests on Chrysalis, including viz. The results look as expected. We're not seeing any convergence in time, so that analysis check fails (presumably as expected).

Both:
comparison
Space:
comparison
Time:
comparison

@xylar
Copy link
Collaborator Author

xylar commented Jan 24, 2025

Here are the analysis plots, for completeness:

Both:
convergence_ssh

Space:
convergence_ssh

Time:
convergence_ssh

@xylar
Copy link
Collaborator Author

xylar commented Jan 24, 2025

@cbegeman, could you give this a quick look when you have time? I don't think you have to spend too much time looking over the code (and you don't need to do any testing) as long as you're happy with the results I posted above.

@sbrus89
Copy link
Contributor

sbrus89 commented Jan 24, 2025

It seems odd that we aren't seeing convergence in time. Is there any reason to expect that?

@xylar
Copy link
Collaborator Author

xylar commented Jan 24, 2025

I think it takes a pretty specific setup for convergence not to be defined more by errors in space or in time. So I'm not that surprised.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Thanks for catching this! Approving based on visual inspection.

@xylar
Copy link
Collaborator Author

xylar commented Jan 24, 2025

Thanks, @cbegeman!

@xylar xylar merged commit 96d168b into E3SM-Project:main Jan 24, 2025
5 checks passed
@xylar xylar deleted the fix-inertial-gravity-wave branch January 26, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants