-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inertial gravity wave test #267
Conversation
This step didn't get updated when we added refinement in just space and just time separately
This was being turned off elsewhere until E3SM-Project#262 for single-layer tests (which this one is by default) but should be turned off by default.
@cbegeman, could you give this a quick look when you have time? I don't think you have to spend too much time looking over the code (and you don't need to do any testing) as long as you're happy with the results I posted above. |
It seems odd that we aren't seeing convergence in time. Is there any reason to expect that? |
I think it takes a pretty specific setup for convergence not to be defined more by errors in space or in time. So I'm not that surprised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar Thanks for catching this! Approving based on visual inspection.
Thanks, @cbegeman! |
The
viz
step didn't get updated when we added refinement in just space and just time separately, so that is the main fix here. Theviz
step is now more similar to the manufactured solution step, which was fixed in #250.This merge also sets the namelist option
config_disable_tr_all_tend = .true.
, which was correctly dropped from thesingle_layer.yaml
in #262 but which now is correctly included in this test'sforward.yaml
.Checklist
Testing
comment in the PR documents testing used to verify the changes