-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IOP lat/lon in rrtmgp interface #2819
Conversation
Setting this as WIP until @bogensch is backfrom vacation. |
Thanks @tcclevenger for your work on this. I will do some testing with this branch and report back. |
I have tested this branch and it absolutely solves the problem pertaining to the incoming solar radiation.... Thus I approve of this PR and this should be merged. Note that, unfortunately, this did not solve the bulk of the differences I am seeing in v0 and v1 DP multi-day runs (like I thought it would) and will continue to debug to track down what the source of the issue is. |
The hunt continues.. Thanks, @bogensch! |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: tcclevenger |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5452 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5730 PASSED (click to see last 100 lines of console output)
|
@tcclevenger I consider this PR ready to go and should be merged in. Thanks. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: tcclevenger |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5479 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5756 PASSED (click to see last 100 lines of console output)
|
@bartgol Can you take a quick look before I manual merge. DIFF in AT is expected. Basically for rrtmgp we need to use the lat/lon from IOP file instead of the one from dynamics in the geometry data, but we don't want to overwrite geometry data for the rest of the run. So I just clone and deep copy if we have IOP object. |
I wonder if it would make sense to have an iop_grid, holding just one dof. Maybe it could simplify some IO stuff. I think we should explore that route when we take on the unification of the interpolation of data from files. |
@bartgol Yes, I completely agree. |
Use IOP lat/lon in rrtmgp interface.
Unrelated change:
dx_short
code no longer needed in iop.