Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit addresses two fixes in Corrective-ML #2824

Merged
merged 1 commit into from
May 16, 2024

Conversation

AaronDonahue
Copy link
Contributor

  1. Fixes precipitation adjustment in Corrective-ML, and it should now do the adjustment on Device when possible.
  2. Fixes the interface to the TQ trained model to include phis and lat.

1. Fixes precipitation adjustment in Corrective-ML, and it should
   now do the adjustment on Device when possible.
2. Fixes the interface to the TQ trained model to include phis and lat.
@AaronDonahue AaronDonahue added bug Something isn't working AT: AUTOMERGE CI: skip eamxx-sa Skip eamxx standalone testing for this PR CI: skip eamxx-v1 Skip eamxx CIME testing for this PR machine learning labels May 15, 2024
@AaronDonahue AaronDonahue requested review from frodre and bartgol May 15, 2024 23:35
@AaronDonahue AaronDonahue added bugfix and removed bug Something isn't working labels May 15, 2024
Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone else take a look, since I don't know anything about the actual ml code. The c++ interface changes look fine though.

Copy link

@frodre frodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@E3SM-Bot
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5426
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;AT: Skip Stand-Alone Testing;AT: Skip v1 Testing;machine learning
PULLREQUESTNUM 2824
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 49856ac
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 3a41dd4
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 5705
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;AT: Skip Stand-Alone Testing;AT: Skip v1 Testing;machine learning
PULLREQUESTNUM 2824
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 49856ac
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 3a41dd4
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: aarondonahue/20240515_mlcorrection_fixes
  • SHA: 49856ac
  • Mode: TEST_REPO

Pull Request Author: AaronDonahue

@E3SM-Bot
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5426
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;AT: Skip Stand-Alone Testing;AT: Skip v1 Testing;machine learning
PULLREQUESTNUM 2824
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 49856ac
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 3a41dd4
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 5705
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;AT: Skip Stand-Alone Testing;AT: Skip v1 Testing;machine learning
PULLREQUESTNUM 2824
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 49856ac
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 3a41dd4
TEST_REPO_ALIAS SCREAM

@E3SM-Bot E3SM-Bot merged commit 335335f into master May 16, 2024
7 checks passed
@E3SM-Bot E3SM-Bot deleted the aarondonahue/20240515_mlcorrection_fixes branch May 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CI: skip eamxx-sa Skip eamxx standalone testing for this PR CI: skip eamxx-v1 Skip eamxx CIME testing for this PR machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants