Always run eamxx workflows on PRs #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
2 times, most recently
from
0420238 to
d2e869b
Compare
mahf708
previously approved these changes
Nov 6, 2024
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
from
d2e869b to
096ef56
Compare
mahf708
previously approved these changes
Nov 6, 2024
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
18 times, most recently
from
97f5d30 to
a4f4a42
Compare
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
from
c06fed2 to
add709c
Compare
bartgol
added
CI: workflow change approved
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
from
add709c to
e415048
Compare
bartgol
added
CI: workflow change approved
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
3 times, most recently
from
3193196 to
9b551ab
Compare
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
3 times, most recently
from
b376a57 to
22692a5
Compare
bartgol
added
CI: workflow change approved
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
9 times, most recently
from
fda2ea8 to
5da234f
Compare
* Remove check-skip-labels action
* For each eamxx workflow
* Run a "pre-process" jobs on ubuntu-latest to
- retrieve labels
- check touched files
Then, add skip logic to other jobs to avoid running unnecessarily
if certain labels are found or touched files are irrelevant
bartgol
force-pushed
the
bartgol/workflows/always-run-eamxx-workflows
branch
from
5da234f to
9b3ae78
Compare
|
@mahf708 I think the current version is the best I could do. It does the job, and we may even use it down the road to avoid starting the jobs if the triggering user does not have the necessary permissions. The down side (super minor) is that we add an extra check to the PR for each workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs can be skipped if paths touched are non-eamxx, but at least they will appear on PR checks. This makes branch protection rules easier to implement, since we can set eamxx checks as REQUIRED (since they will always be there)