Vega Related Changes - Addition of Header #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartyanambiar
commented
Aug 9, 2023
Comment on lines
+934
to
+937
| data = f.read() | ||
| if chart!="nucleotide-distribution": | ||
| data = "key\tvalue" + "\n" + data | ||
| return Response( data) |
There was a problem hiding this comment.
I didn't want to make any major changes hence went ahead with this easy approach.
If there is a better way to do it. Pls do let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SandyRogers @mberacochea
This PR is created to include code to generate tsv files with headers for
AnalysisQCChartViewSet.This includes endpoints such as =>
gc-distribution,nucleotide-distribution,seq-lengthandsummary.The changes have been brought because the proposed Charting library for EBI website Vega expects the data to have headers.