-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made adjustments to support having analysis_summary inside the analys… #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MGS-sails ! Couple of suggested updates inline.
It looks like the QC upload test is also failing, so that one will need updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we squash these multiple migrations? (Or since they look like temporary testing things, delete all of the migration files, reset the sqlite EMG fixture to the one from the client repo, and run makemigrations
again to just get a single migration with the needed schema changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SandyRogers I've squashed the migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, I agree with Sandy's suggestions. We should also remove the tables we migrated to the json field after this is done
@MGS-sails One more thing I forgot, sorry: can we please update the Once we release this, run the migration, we can then do another PR with the table cleanup and potentially rename the |
…sis_summary_json field
@SandyRogers the tests are now passing |
…is_job model