Skip to content

Commit

Permalink
gh-806: Increase candidate name length to 250
Browse files Browse the repository at this point in the history
this fixes #806
  • Loading branch information
dinukadesilva committed Aug 5, 2020
1 parent 62391ae commit 09db6d5
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
30 changes: 30 additions & 0 deletions results-tabulation-api/migrations/versions/30d245f39754_.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
"""empty message
Revision ID: 30d245f39754
Revises: dc4dc715ee10
Create Date: 2020-08-05 21:32:53.743938
"""
from alembic import op
import sqlalchemy as sa
from sqlalchemy.dialects import mysql

# revision identifiers, used by Alembic.
revision = '30d245f39754'
down_revision = 'dc4dc715ee10'
branch_labels = None
depends_on = None


def upgrade():
op.alter_column('candidate', 'candidateName',
existing_type=mysql.VARCHAR(collation='utf8mb4_unicode_ci', length=100),
type_=sa.String(length=250),
existing_nullable=False)


def downgrade():
op.alter_column('candidate', 'candidateName',
existing_type=sa.String(length=250),
type_=mysql.VARCHAR(collation='utf8mb4_unicode_ci', length=100),
existing_nullable=False)
2 changes: 1 addition & 1 deletion results-tabulation-api/orm/entities/Candidate.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class CandidateModel(db.Model):
__tablename__ = 'candidate'
candidateId = db.Column(db.Integer, primary_key=True, autoincrement=True)
candidateName = db.Column(db.String(100), nullable=False)
candidateName = db.Column(db.String(250), nullable=False)
candidateNumber = db.Column(db.String(100), nullable=False, default="")
candidateType = db.Column(db.String(50), nullable=False, default=CANDIDATE_TYPE_NORMAL)
candidateProfileImageFileId = db.Column(db.Integer, db.ForeignKey(Image.Model.__table__.c.fileId), nullable=True)
Expand Down

0 comments on commit 09db6d5

Please sign in to comment.