-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transverse Alignment Support #490
Conversation
c166bf0
to
0ac6c91
Compare
@@ -65,9 +65,9 @@ Usage | |||
:hidden: | |||
|
|||
usage/how_to_run | |||
usage/examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved forward as in WarpX: showing examples before API details feels more user-friendly :)
0ac6c91
to
a24cd13
Compare
a24cd13
to
98785cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions, especially to avoid mixing variable values in new/old coordinate system.
In general, "Transversal" is usually written as "Transverse".
Don't we also need to modify InitElement.cpp? Could also be a follow-up.
Thanks for the review comments!
|
34c9813
to
17a358a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a test example in mind with parameters we can try. I'll copy your branch and try to get this working tomorrow morning.
28c6555
to
a90c64f
Compare
715b8dc
to
9de793d
Compare
0f17351
to
ef51e58
Compare
Create a mixin class that can be used for transversal alignment offsets and tilts. Co-authored-by: Chad Mitchell <chadmitchell@lbl.gov>
Co-authored-by: Chad Mitchell <chadmitchell@lbl.gov>
Now: `rotation error in the transverse plane`
c716af1
to
1f9d23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. In the end, the code change to each individual element is minor and easily duplicated.
Thanks! Yes, that's the idea. Another cool property of this mixin class approach is, that we see from the type of a class if it can be misaligned or not. If we need it later on, we can also add an explicit alignment element from this mixin class, but currently this seems to a user friendly way to expose it in each element (and the calculation is nicely fused in the kernel that does the map advance). |
Add support for non-ideal transverse alignment in elements.
This adds horizontal and vertical translation offsets per element as well as rotation in the x-y plane.
Checklist
Alignment