Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyTorch surrogate example #547

Merged
merged 21 commits into from
Mar 20, 2024
Merged

Update PyTorch surrogate example #547

merged 21 commits into from
Mar 20, 2024

Conversation

RTSandberg
Copy link
Member

This PR updates the PyTorch surrogate model example from PR #482 to reflect work done for the PASC revision.
It also improves on the original presentation.

New figures here:
Schematic:
schema_15_stages

Moments:
lpa_ml_surrogate_moments

Initial phase space:
initial_phase_spaces

Final phase space:
stage_14_phase_spaces

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2024
View reviewed changes
examples/pytorch_surrogate_model/run_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/run_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/visualize_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/run_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
examples/pytorch_surrogate_model/run_ml_surrogate_15_stage.py Fixed Show fixed Hide fixed
@ax3l ax3l added the component: documentation Docs, readme and manual label Mar 13, 2024
@ax3l ax3l self-requested a review March 13, 2024 02:57
@ax3l ax3l self-assigned this Mar 13, 2024
ax3l
ax3l reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that's awesome!

Do you want to:

  • update the .. figure:: URLs,
  • remove the 9 stage files?

@RTSandberg
Copy link
Member Author

Yes, I just updated the figures and cleared out the 9 stage files

@RTSandberg RTSandberg force-pushed the topic-update-surrogate-example branch from 7164318 to 3e0c218 Compare March 15, 2024 22:07
ax3l
ax3l reviewed Mar 16, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent and like it has all the updates we added for device code in the revision 🎉

examples/pytorch_surrogate_model/README.rst Outdated Show resolved Hide resolved
examples/pytorch_surrogate_model/README.rst Outdated Show resolved Hide resolved
ax3l
ax3l approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀 ✨

@ax3l ax3l merged commit 9a106c6 into ECP-WarpX:development Mar 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
component: documentation Docs, readme and manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RTSandberg @ax3l