Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aperture Backwards Compat. #804

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 18, 2025

Fix #803:
Do not add the old parameter to ParmParse. Just check if it is there and only add aperture_x/y.

Follow-up to a bug introduced in #788

Do not add the old parameter to `ParmParse`. Just check if it is there
and only add `aperture_x/y`.
@ax3l ax3l added the bug Something isn't working label Jan 18, 2025
@ax3l ax3l requested a review from cemitch99 January 18, 2025 00:24
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

@cemitch99 cemitch99 merged commit fe6e789 into ECP-WarpX:development Jan 18, 2025
16 checks passed
@ax3l ax3l deleted the fix-backwards-compat-xmax branch January 18, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using bool variable with queryAdd for elements appearing more than once can yield false -> true
2 participants