Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service accounts #140

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add service accounts #140

merged 2 commits into from
Oct 22, 2024

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Oct 21, 2024

Summary

Brings a fallback claim for those users that do not have a user name, so considered as service accounts. The name of the claim is configured with servicename_claim.

It also tries to avoid the refresh for those users that cannot be refreshed. This assumes the users that need to be refreshed actually have a valid refresh token


Related issue :

And do not try to refresh identities that cannot be refreshed
Copy link

@gonimoro gonimoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

@gonimoro gonimoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand this PR needs some checks before merging

Copy link

@gonimoro gonimoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@enolfc enolfc merged commit 0835136 into EGI-Federation:main Oct 22, 2024
3 checks passed
@enolfc enolfc deleted the refresh-anon branch October 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants