Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update poetry lock #20

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Update poetry lock #20

merged 2 commits into from
Aug 23, 2024

Conversation

sebastian-luna-valero
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero commented Aug 22, 2024 •
edited
Loading

Summary

Update poetry lock.

The current version fedcloudclient is 1.4.2 in the existing poetry.lock which throws:

fedcloud-vo-monitor --oidc-access-token $OS_ACCESS_TOKEN                               
Site config in file https://raw.githubusercontent.com/EGI-Federation/fedcloud-catchall-operations/main/sites/GRNET-OPENSTACK.yaml is in wrong format
Exception: Additional properties are not allowed ('images' was unexpected)

Updating to fedcloudclient version 1.4.3 solves the issue.

Thanks for reporting @mrorro. Could you please test before we merge?

Related issue :

@enolfc
Copy link
Collaborator

enolfc commented Aug 22, 2024

Should this be reflected also in https://github.com/EGI-Federation/fedcloud-vm-monitoring/blob/main/pyproject.toml#L14?

@sebastian-luna-valero
Copy link
Member Author

Indeed, thanks for the reminder!

I have just done it.

enolfc
enolfc approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-luna-valero
Copy link
Member Author

Merging now.

@mrorro feel free to test and report back any issues.

@sebastian-luna-valero sebastian-luna-valero merged commit 3e19c29 into main Aug 23, 2024
16 checks passed
@sebastian-luna-valero sebastian-luna-valero deleted the update-lock branch August 23, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enolfc enolfc enolfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-luna-valero @enolfc