Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New accounting check tool #25

Merged
merged 19 commits into from
Dec 12, 2024
Merged

New accounting check tool #25

merged 19 commits into from
Dec 12, 2024

Conversation

enolfc
Copy link
Collaborator

@enolfc enolfc commented Nov 22, 2024

Summary

  • Add a site accounting tool
  • Renamed cli to vm_monitor_cli to avoid conflicts
  • Add new depedencies and tool

Related issue :

@enolfc
Copy link
Collaborator Author

enolfc commented Nov 22, 2024

It's working but the linter will scream now. Also needs a bit of cleaner output

@enolfc
Copy link
Collaborator Author

enolfc commented Nov 26, 2024

I added AppDB checks as well for the SLAs, this makes the tool more integrated with the rest of the repo

sebastian-luna-valero
sebastian-luna-valero reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Minor review until I get my x509 certificate to do a full test

fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
enolfc and others added 3 commits December 4, 2024 13:43
@enolfc @sebastian-luna-valero
Apply suggestions from code review
551dfe8 
Co-authored-by: Sebastian Luna-Valero <sebastian-luna-valero@users.noreply.github.com>
@enolfc
Add configuration for markdownlint
442a9f8
@enolfc
Linting fixes
6f11ba2
sebastian-luna-valero
sebastian-luna-valero reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for prettier output

fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
@sebastian-luna-valero
Copy link
Member

Additionally, I am troubleshooting something else so please let me get back to you on that later

enolfc and others added 2 commits December 11, 2024 11:49
@enolfc @sebastian-luna-valero
Apply suggestions from code review
9cd327f 
Co-authored-by: Sebastian Luna-Valero <sebastian-luna-valero@users.noreply.github.com>
@enolfc
Reformat with black
fc5fd41
@enolfc enolfc marked this pull request as ready for review December 11, 2024 12:26
sebastian-luna-valero
sebastian-luna-valero reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further suggestions to improve output

fedcloud_vm_monitoring/sla_monitor_cli.py Show resolved Hide resolved
fedcloud_vm_monitoring/sla_monitor_cli.py Show resolved Hide resolved
sebastian-luna-valero
sebastian-luna-valero requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update existing info, otherwise it will be overwritten

fedcloud_vm_monitoring/goc.py Outdated Show resolved Hide resolved
sebastian-luna-valero
sebastian-luna-valero requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing no

fedcloud_vm_monitoring/sla_monitor_cli.py Outdated Show resolved Hide resolved
@enolfc @sebastian-luna-valero
Apply suggestions from code review
59d78bd 
Co-authored-by: Sebastian Luna-Valero <sebastian-luna-valero@users.noreply.github.com>
sebastian-luna-valero
sebastian-luna-valero approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

Let's give it a try. I have a couple of additional ideas but I will open separate PRs for them.

@enolfc enolfc merged commit 7639632 into EGI-Federation:main Dec 12, 2024
3 checks passed
@enolfc enolfc deleted the accounting branch December 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-luna-valero sebastian-luna-valero sebastian-luna-valero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enolfc @sebastian-luna-valero