Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messages] Fix bug where DoT messages stop coming out when mob dies. #4249

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

noudess
Copy link
Contributor

@noudess noudess commented Apr 9, 2024

Description

My old PR #2289 accidentally removed messages for DoTs that are cast by NPCs on PCs after the NPC dies.

On live:

image

We now match this.

Additionally I created an issue #4248 because its always been true on live that DoTs live past the corpse. That change on eqemu is larger in scale and I think should be separate from this PR. On live, the damage still occurs and looks like this:

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Killed a mob after getting DoTTed and made sure damage was getting done and we got the messages again.

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@noudess noudess requested a review from Aeadoin April 9, 2024 19:28
@Akkadius Akkadius merged commit a5e8a4c into EQEmu:master Apr 15, 2024
1 check passed
@Akkadius Akkadius mentioned this pull request Apr 15, 2024
@Akkadius Akkadius mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants