Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Selenoid engine #82

Merged
merged 16 commits into from
May 23, 2024
Merged

Add Selenoid engine #82

merged 16 commits into from
May 23, 2024

Conversation

mg-diego
Copy link
Contributor

@mg-diego mg-diego commented Aug 18, 2023 •
edited
Loading

Add Selenoid engine

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

  • Add new Selenoid engine
  • Update some third party versions

@mg-diego mg-diego mentioned this pull request Aug 18, 2023
Closed
1 task
LopezMDidac
LopezMDidac requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@LopezMDidac LopezMDidac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review sonar comments.

mg-diego added 4 commits October 6, 2023 18:12
Merge branch 'main' into feature/selenoid
c27db19 
# Conflicts:
#	src/Engines/TestWare.Engines.Selenium/Configuration/Capabilities.cs
Solve merge conflict
c834527
Solve PR comments
e120df1
Solve PR comments
da0a0bb
@mg-diego
Copy link
Contributor Author

mg-diego commented Oct 6, 2023 •
edited
Loading

Review sonar comments.

Comments on own code solved, remaining ones are from the Selenium Extras third party code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
65 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

@mg-diego mg-diego merged commit 1ee6cf1 into main May 23, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/selenoid branch May 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LopezMDidac LopezMDidac LopezMDidac requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mg-diego @LopezMDidac