-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Eulerian dycore #1215
base: cam_development
Are you sure you want to change the base?
remove Eulerian dycore #1215
Conversation
A quick grep for "eul" in your modified code showed:
There were plenty of other places in the CAM code where "eulerian" is still used, but I think they don't relate to the dycore |
I didn't touch the code in tools/nudging because it's not part of the EUL dycore, and more importantly, I don't have a way to test whether or not I broke it. But I'll go ahead and remove the Eulerian option if you think that's best. I've removed bld/scripts/remapfv2eul.ncl. The eulc references in namelist_definition.xml are related to vertical advection in SCAM. I think that use is independent of the EUL dycore. @jtruesdal, could you comment? |
@patcal - Can you advise us on whether or not the eul option should be removed from the tools/nudging code, since this PR is removing the Eulerian dycore completely from CAM? |
@brian-eaton I would like to keep the eulc namelist definitions for SCAM as we hope to provide a simple eularian vertical transport for the single column model that is not associated with the current eul dycore. |
@cacraigucar, I've removed the references to the EUL dycore from the nudging tools. |
@brian-eaton thanks for adding the test grid issue here. I noticed that even though you have a single line for each issue at the top, it didn't add them to the development, which means they won't auto close. So I did that by hand for the bottom two, and the top one didn't show up in my simple search. If you figure you why they didn't get added to development let me know. |
@jtruesdal - I believe we still need your reply to this question? |
@cacraigucar I did answer above saying I would like to keep the namelist options related to SCAM which refer to a generic eulerian vertical advection not the eul dycore. |
@jtruesdal - Thanks - sorry I missed that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the requested mods.
Resolves #1170 - Remove Eulerian dycore from cam_development
Resolves #1148 - Update fire_emissions_factors in hist_trop_strat_vbsfire_cam6 usecase
. Note that this only changes answers for compset FCfireHIST which is not tested in the aux_cam group.
Resolves #1237 - Remove Eulerian dycore grids from our testing