Add capability for SCAM forcing based on gridded met fields. #595
Conversation
Merge remote-tracking branch 'ESCOMP/cam_development' into cam_development
…/CAM into cam_development
JulioTBacmeister
changed the title
|
@JulioTBacmeister could you add @jtruesdal as a developer on your repo if it's OK for me to make changes to this branch for the PR. |
|
@jtruesdal I've made you a collaborator and github implies you should have received an invite of some sort. Let me know if I should do something else. |
|
Jim Edwards came across the following when debugging our CICE/SCAM issues: Because the namelist variable scm_ana_frc_file_template is a template rather than an actual file, this message appears when you build:
To avoid this, we may need a change to CAM's buildnml so that this isn't written to the |
|
Yes. I've noticed this message. The model nevertheless builds and runs without issues. This should have also come up when the nudging code was incorporated - it uses a similar template. |
Gotcha. I'll open a low-priority issue for the nudging message. |
|
OK, bringing this up again because it looks like the logic can handle the nudging template file because it does not see it as an absolute path (and thus we do not get the warning). Because of the "%y/" at the start of the scm_ana_frc_file_template file, we get the warning for this new variable. If you replace line 4405 in bld/build_namelist with the following (to not write the variables whose pathnames start with '%' to the cam.input_data_list file), it should remove the warning: I'm also happy to make a PR to your branch with this change. Thanks! |
Merge branch 'cam_development' of https://github.com/JulioTBacmeister/CAM into cam_development
|
@peverwhee @jtruesdal - I made the change in build_namelist on my branch and pushed it to origin. Would you check it? |
|
@JulioTBacmeister Looks good to me. Sorry my code snippet was missing a parenthesis! Thanks! |
| <entry id="scm_ana_frc_file_template" type="char*128" input_pathname="abs" category="scam" | ||
| group="scam_nl" valid_values="" > | ||
| template for analysis forcing dataset. | ||
| Default: set by build-namelist. | ||
| </entry> |
There was a problem hiding this comment.
This variable is a string, not a filename (path), therefore, it should not have the input_pathname attribute. I believe this is the source of the build-namelist problems.
bld/build-namelist
Outdated
| if (!($pathname =~ '%.*')) { | ||
| print $fh "$var = $pathname\n"; |
There was a problem hiding this comment.
I do not think this should be needed (see below) and could have unintended effects.
There was a problem hiding this comment.
Should these lines be removed altogether? Or replaced with what was there before?
There was a problem hiding this comment.
It should be replaced with what was there before. I opened a PR with the changes if that helps (you can also close it if you don't need it):
Apologies for any whiplash you may be experiencing.
Revert build-namelist change and remove input_pathname argument
Merge remote-tracking branch 'refs/remotes/origin/cam_development' into cam_development
|
Removed Not sure what to do with Want to note problems with Functionality of make_basecase.auto.csh should incorporated somewhere, i,e. new compset, new script like 'create_newcase' Need for STUB_iop.nc should also be looked at. |
|
@nusbaume @cacraigucar and I recommended (via email) that Julio remove the shell scripts and ncdata file from the scam_STUB usermods directory. Documenting that here. XML variables set in the shell script(s) can be set in scam_STUB/shell_commands and variables written to user_nl_cam can be added to scam_STUB/user_nl_cam |
|
@JulioTBacmeister and @adamrher - Is this Stub IOP another IOP which we want to support? If so, I would suggest that the user_nl_cam and shell_commands be put in cime_config/usermods_dirs/scam_Stub_IOP or something like that. You can see what was done for cime_config/usermods_dirs/scam_arm97 as an example. @jtruesdal may be able to give some addtional guidance as he's done this more recently than I have. |
|
@cacraigucar I agree that this needs to be looked at and will meet with Julio to discuss options. |
…/CAM into cam_development This is bringing stuff from Cheyenne: 1) Allow runs on Cheyenne; 2) Enable L93
| protocol = svn | ||
| repo_url = https://github.com/larson-group/clubb_release/tags/ | ||
| tag = clubb_4ncar_20220311_f51de38/src/CLUBB_core | ||
| required = True | ||
|
|
||
| [silhs] | ||
| local_path = src/physics/silhs | ||
| protocol = git | ||
| repo_url = https://github.com/ESCOMP/SILHS_CESM | ||
| tag = silhs_clubb_release_b76a124_20200220_c20200320 | ||
| protocol = svn | ||
| repo_url = https://github.com/larson-group/clubb_release/tags/ | ||
| tag = clubb_4ncar_20220311_f51de38/src/SILHS |
There was a problem hiding this comment.
@JulioTBacmeister - Are these changes really needed for your SCAM PR? Hopefully you can use the tags that are currently being used in CAM instead
There was a problem hiding this comment.
I want to use the "new" CLUBB external brought in with cam6_3_059. This is so that we can assess prognostic momentum transport using SCAM.
|
Superseded by PR #628 |
This capability currently requires pre-computed gridded fields on FV latlon 1 degree grid
Have run a number of cases using this capability - can provide user_nl_cam as well path to gridded ERA reanalysis.
Have also run with this capability is off and standard SCAM IOPs. Answers look fine but have not done rigorous testing.
closes #594