atmos_phys0_20_002: Bring in acc directives to enable GPU runs in SIMA#346
Merged
peverwhee merged 180 commits intoESCOMP:mainfrom Jan 29, 2026
Merged
atmos_phys0_20_002: Bring in acc directives to enable GPU runs in SIMA#346peverwhee merged 180 commits intoESCOMP:mainfrom
peverwhee merged 180 commits intoESCOMP:mainfrom
Conversation
…ospheric_physics into rrtmgp-diagnostics
nusbaume
reviewed
Jan 13, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @peverwhee! I had one question about a directive, and a request to update the PR description, but otherwise this PR looks good to me!
nusbaume
approved these changes
Jan 29, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for getting this working @peverwhee! I just had a couple requests for comments (but they don't require a re-review).
jimmielin
approved these changes
Jan 29, 2026
Member
jimmielin
left a comment
There was a problem hiding this comment.
Thanks @peverwhee! Minor suggestions as promised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name: atmos_phys0_20_002
Originator(s): peverwhee
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
addresses #154
closes #325
List all namelist files that were added or changed: n/a
List all files eliminated and why: n/a
List all files added and what they do: n/a
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed: n/a
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? no
If yes to the above question, describe how this code was validated with the new/modified features: