-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Python portrait plot diagnostic #3551
Conversation
what a noble venture, Lukas! Godspeed 🏁 🍺 |
… into perfmetric_python
Sorry, one more comment. While testing this I noticed that the font size was getting very large when lots of datasets are used. A very easy and flexible way to allow changing this in the diagnostic is via setting This can be done with basically just one line, see here. Would be great if that would also be possible! Thanks!! |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged now, thanks everyone, this is awesome 🚀
@schlunma the nightly dev test fails for this recipe, I think we need to add some datasets in the recipe test, also noticed that the config file has both |
Good point. I wasn't aware of that test...Maybe we just need to remove it from there. I don't see the point in running that every night. Funny thing is that the normal version also finished in <3 min for me (on an entire Levante node though), which is also pretty fast in my opinion. How about that? I wouldn't know how to expand the test so it can handle these OBS files. |
cheers, Manu! I am fine with not testing for it if you think this should not really be tested for it 🍺 |
See #3871 |
Description
portrait plot
from NCL perfmetrics in python #3550Before you get started
portrait plot
from NCL perfmetrics in python #3550Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: