Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python portrait plot diagnostic #3551

Merged
merged 77 commits into from
Jan 22, 2025
Merged

Added Python portrait plot diagnostic #3551

merged 77 commits into from
Jan 22, 2025

Conversation

lukruh
Copy link
Contributor

@lukruh lukruh commented Mar 20, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

what a noble venture, Lukas! Godspeed 🏁 🍺

@lukruh lukruh added this to the v2.11.0 milestone Apr 16, 2024
@schlunma
Copy link
Contributor

Sorry, one more comment. While testing this I noticed that the font size was getting very large when lots of datasets are used. A very easy and flexible way to allow changing this in the diagnostic is via setting matplotlib.rcParams.

This can be done with basically just one line, see here. Would be great if that would also be possible!

Thanks!!

@schlunma schlunma removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jan 22, 2025
@schlunma schlunma changed the title recreate perfmetrics portrait plot in python Added Python portrait plot diagnostic Jan 22, 2025
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now, thanks everyone, this is awesome 🚀

@schlunma schlunma merged commit 425e233 into main Jan 22, 2025
8 checks passed
@schlunma schlunma deleted the perfmetric_python branch January 22, 2025 16:48
@valeriupredoi
Copy link
Contributor

@schlunma the nightly dev test fails for this recipe, I think we need to add some datasets in the recipe test, also noticed that the config file has both search_esgf: never and search_esgf: when_missing (the latter taking priority, of course) 🍺

@schlunma
Copy link
Contributor

schlunma commented Jan 24, 2025

Good point. I wasn't aware of that test...Maybe we just need to remove it from there. I don't see the point in running that every night. Funny thing is that the normal version also finished in <3 min for me (on an entire Levante node though), which is also pretty fast in my opinion.

How about that? I wouldn't know how to expand the test so it can handle these OBS files.

@valeriupredoi
Copy link
Contributor

cheers, Manu! I am fine with not testing for it if you think this should not really be tested for it 🍺

@schlunma
Copy link
Contributor

See #3871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic new recipe Use this label if you are adding a new recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recreate portrait plot from NCL perfmetrics in python
9 participants