Open
Conversation
Collaborator
|
Почините CI |
изменения main
new check
p-senichenkov
approved these changes
Dec 14, 2025
| void From10To2(int* arr, int n, int d) | ||
| { | ||
| if (d < 0) { | ||
| d = 256 + d; |
Collaborator
There was a problem hiding this comment.
Это не совсем честно. Если бы Вы действительно использовали 8-битный тип, это бы не сработало. Во-первых, там нет числа 256.
Во-вторых, это основано на том, что переполнение игнорируется. А это не так. Переполнение для знаковых чисел -- это UB.
| return n; | ||
| } | ||
|
|
||
| void summa(int* arr1, int* arr2, int* res) |
Collaborator
There was a problem hiding this comment.
Не надо использовать транслит:
Suggested change
| void summa(int* arr1, int* arr2, int* res) | |
| void sum(int* arr1, int* arr2, int* res) |
| } | ||
| } | ||
|
|
||
| int From2To10(int* arr) |
Collaborator
There was a problem hiding this comment.
Решите, Вы используете для функций PascalCase или camelCase. Должно быть везде одинаково
Collaborator
|
Кажется, здесь ничего не изменилось |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.