Open
Conversation
chernishev
reviewed
Nov 11, 2025
src/optimal_sort/functions.h
Outdated
| @@ -0,0 +1 @@ | |||
| void quicksort(int* mas, int size); No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
не хватает include guards
chernishev
reviewed
Nov 11, 2025
src/optimal_sort/instuction.md
Outdated
chernishev
reviewed
Nov 11, 2025
src/optimal_sort/instuction.md
Outdated
| @@ -0,0 +1 @@ | |||
| write "make -f Makefile" No newline at end of file | |||
chernishev
reviewed
Nov 11, 2025
src/optimal_sort/main.c
Outdated
| } | ||
| printf("%d", count); | ||
| free(numbers); | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
не тот код возвращаете, читайте условие внимательно
chernishev
reviewed
Nov 11, 2025
| while (scanf("%d", &arr[index]) == 1) { | ||
| index++; | ||
| } | ||
| int* numbers = (int*)malloc(sizeof(int) * index); |
chernishev
reviewed
Nov 11, 2025
src/optimal_sort/Makefile
Outdated
| @@ -0,0 +1,6 @@ | |||
| all: | |||
| gcc -S quicksort.c -o quicksort.s | |||
| gcc main.c quicksort.c -o qsort | |||
Collaborator
There was a problem hiding this comment.
тут должно быть не так
chernishev
reviewed
Nov 11, 2025
Collaborator
chernishev
left a comment
chernishev
left a comment
There was a problem hiding this comment.
пока 3/5. замечания на github
p-senichenkov
approved these changes
Dec 18, 2025
src/optimal_sort/Makefile
Outdated
| @@ -0,0 +1,6 @@ | |||
| all: | |||
| gcc -S quicksort.c -o quicksort.s | |||
| gcc main.c quicksort.c -o qsort | |||
src/optimal_sort/quicksort.c
Outdated
| @@ -0,0 +1,29 @@ | |||
| #include "functions.h" | |||
Collaborator
There was a problem hiding this comment.
Хедер и его исходный файл должны называться одинаково
src/optimal_sort/main.c
Outdated
Comment on lines
14
to
16
| for (int i = 0; i < index; i++) { | ||
| numbers[i] = arr[i]; | ||
| } |
Collaborator
There was a problem hiding this comment.
Можно воспользоваться mempcy
p-senichenkov
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.