Added configuration file for parameters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstairs
reviewed
Nov 14, 2023
justfile
Outdated
Comment on lines
22
to
23
| dvc pull data/root/ETSIPETscanner_mIEC_1.root | ||
| dvc pull data/root/scanner_geometry.json |
There was a problem hiding this comment.
Can we write
dvc pull data/root/ETSIPETscanner_mIEC_1.root data/root/scanner_geometry.json?
johnstairs
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adding a configuration (JSON) file for all the geometry parameters to avoid hard coding them in the main.cpp
Testing performed
Manual testing
Related issues
closes #8
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: