Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain parent pages #234

Merged
merged 17 commits into from
Feb 13, 2025
Merged

Domain parent pages #234

merged 17 commits into from
Feb 13, 2025

Conversation

shoaibsufi
Copy link
Collaborator

This PR address #219 and #221

@shoaibsufi shoaibsufi requested a review from anenadic February 12, 2025 16:49
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for everse-rsqkit-testing ready!

Name Link
🔨 Latest commit db08ab2
🔍 Latest deploy log https://app.netlify.com/sites/everse-rsqkit-testing/deploys/67ade1cf586552000846e6b6
😎 Deploy Preview https://deploy-preview-234--everse-rsqkit-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shoaibsufi
Copy link
Collaborator Author

Once this is done I suggest we close #121 also and add a new ticket for each outstanding research cluster/community - these being ENVRI and ELIXIR

Copy link
Contributor

@anenadic anenadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR - thank you @shoaibsufi. Individual science slucter pages are missing links to various recourses but we can ask people to fix those after this is merged.

I fixed a few typos directly on the branch (not way to do them so you can review - sorry) and there are a few that you can review.

One question - the existing 3 science cluster pages do not currently follow the template - do we still have to update them and align?

shoaibsufi and others added 5 commits February 13, 2025 12:03
Co-authored-by: Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Co-authored-by: Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Co-authored-by: Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Co-authored-by: Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Co-authored-by: Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
@shoaibsufi
Copy link
Collaborator Author

This is a great PR - thank you @shoaibsufi. Individual science slucter pages are missing links to various recourses but we can ask people to fix those after this is merged.

I fixed a few typos directly on the branch (not way to do them so you can review - sorry) and there are a few that you can review.

One question - the existing 3 science cluster pages do not currently follow the template - do we still have to update them and align?

Thanks @anenadic and I have committed the typo suggestions. With regards to the template and existing pages - the plan is to go back to Guido/WP4 and perhaps these can be taken from the pilot presentations or perhaps WP4 will go back to the pilots themselves and asking them to fill them in.

@shoaibsufi shoaibsufi merged commit 9e5a1d3 into main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants