Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenate sign lines to allow for multiline search #706

Open
wants to merge 2 commits into
base: fabric
Choose a base branch
from
Open

Concatenate sign lines to allow for multiline search #706

wants to merge 2 commits into from

Conversation

xpple
Copy link
Collaborator

@xpple xpple commented Jan 7, 2025 •
edited
Loading

Closes #705.

@xpple xpple added the enhancement New feature or request label Jan 7, 2025
@xpple xpple requested a review from Earthcomputer January 7, 2025 14:47
@Earthcomputer
Copy link
Owner

I was thinking that the regex argument type and possible the regexes themselves would also need to be adjusted to support multiple lines.

@xpple
Copy link
Collaborator Author

xpple commented Jan 7, 2025

Assuming you are referring to modifiers like g and m: g is pointless because we are looking for any match and m already works.

@xpple
Copy link
Collaborator Author

xpple commented Jan 7, 2025

Upon closer inspection m does not in fact work 😄.

@xpple
Copy link
Collaborator Author

xpple commented Jan 7, 2025

Should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Earthcomputer Earthcomputer Awaiting requested review from Earthcomputer

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I use /csignsearch to find signs with required text being across multiple lines?
2 participants
@xpple @Earthcomputer