Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: EasyPostTimeInTransitData inaccessible #304

Closed
zarubto4 opened this issue Mar 21, 2024 · 2 comments · Fixed by #305
Closed

[Bug]: EasyPostTimeInTransitData inaccessible #304

zarubto4 opened this issue Mar 21, 2024 · 2 comments · Fixed by #305
Assignees
Labels
ready Pull request is ready to merge

Comments

@zarubto4
Copy link

Software Version

7.1.0

Language Version

Java 17

Operating System

MacOS

What happened?

Hi,

in object EasyPostTimeInTransitData here
https://github.com/EasyPost/easypost-java/blame/master/src/main/java/com/easypost/model/EstimatedDeliveryDate.java
you have all values as private without abstract parent services.

So it's not possible to use that in Java.

Snímek obrazovky 2024-03-21 v 2 20 24

What was expected?

Set is as public or create abstract class with @Getter

Sample Code

public String getPlannedShipDate() {
        return plannedShipDate;
    }

 public String getEasyPostEstimatedDeliveryDate() {
        return easypostEstimatedDeliveryDate;
    }

Relevant logs

No response

@zarubto4 zarubto4 added the triage Issue is being researched label Mar 21, 2024
@nwithan8 nwithan8 changed the title [Bug]: [Bug]: EasyPostTimeInTransitData inaccessible Mar 21, 2024
@nwithan8 nwithan8 self-assigned this Mar 21, 2024
@nwithan8 nwithan8 linked a pull request Mar 21, 2024 that will close this issue
4 tasks
@nwithan8
Copy link
Contributor

@zarubto4 Thank you for bringing this to our attention. It appears the class was not explicitly marked as public, making it inaccessible as you've pointed out. This is being rectified in #305 and will be included in our next release.

@nwithan8 nwithan8 added ready Pull request is ready to merge and removed triage Issue is being researched labels Mar 21, 2024
@jchen293
Copy link
Contributor

@zarubto4 We have just released v7.1.1 for this patch, thanks for submitting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to merge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants