Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Public accessibility of EasyPostTimeInTransitData class #305

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nwithan8
Copy link
Contributor

Description

EasyPostTimeInTransitData was not explicitly marked as public, making it inaccessible to end-users.

Closes #304

Testing

  • Unit test updated to confirm class/property of EstimatedDeliveryDate is accessible

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team March 21, 2024 06:43
@nwithan8 nwithan8 linked an issue Mar 21, 2024 that may be closed by this pull request
@nwithan8 nwithan8 changed the title [Fix] Public accessibility of EasyPostTimeInTransitData class [Fix] Public accessibility of EasyPostTimeInTransitData class Mar 21, 2024
@nwithan8 nwithan8 merged commit 44c670c into master Mar 21, 2024
17 checks passed
@nwithan8 nwithan8 deleted the 304-bug-easyposttimeintransitdata-inaccessible branch March 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: EasyPostTimeInTransitData inaccessible
3 participants