Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Public accessibility of EasyPostTimeInTransitData class #305

Merged
merged 1 commit into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## Next Releease

- Fix `EasyPostTimeInTransitData` class and `easypostTimeInTransitData` property of `EstimatedDeliveryDate` class being publicly inaccessible

## v7.1.0 (2024-01-08)

- Adds `allChildren` function in User service to get a paginated list of child users
Expand Down
10 changes: 10 additions & 0 deletions src/main/java/com/easypost/model/EasyPostTimeInTransitData.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.easypost.model;

import lombok.Getter;

@Getter
public class EasyPostTimeInTransitData {
private TimeInTransit daysInTransit;
private String easypostEstimatedDeliveryDate;
private String plannedShipDate;
}
6 changes: 0 additions & 6 deletions src/main/java/com/easypost/model/EstimatedDeliveryDate.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,3 @@ public class EstimatedDeliveryDate {
private Rate rate;
}

@Getter
class EasyPostTimeInTransitData {
private TimeInTransit daysInTransit;
private String easypostEstimatedDeliveryDate;
private String plannedShipDate;
}
3 changes: 3 additions & 0 deletions src/test/java/com/easypost/ShipmentTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,9 @@ public void testRetrieveEstimatedDeliveryDate() throws EasyPostException {
.retrieveEstimatedDeliveryDate(shipment.getId(), Fixtures.plannedShipDate());
for (EstimatedDeliveryDate estimatedDeliveryDate : estimatedDeliveryDates) {
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getEasypostEstimatedDeliveryDate());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getDaysInTransit());
assertNotNull(estimatedDeliveryDate.getEasypostTimeInTransitData().getDaysInTransit().getPercentile99());
}
}
}
Loading