27 new sound effects #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh the stuff from maple was not submitted yet |
|
half of it was sent before. The rest appeared while I had no time to properly format and do a PR |
Ghabry
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
The goal of lumiscosity was to create sounds from scratch that are close to the RTP sounds plus some variation. Imo that goal was achieved.
I also agree with replacing some of the existing sounds.
The only one that imo sounds the same (just with less volume) is Cursor2.wav but this is honestly so short and basic that I don't think you can even copyright it. xD
fdelapena
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.