139 prepare for magnetism refl1d #140
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| sample = _build_sample(self.storage, model_name) | ||
| probe = _get_probe( | ||
| q_array=np.linspace(0.001, 0.3, 10), | ||
| dq_array=np.linspace(0.001, 0.3, 10), # TODO why would we use a steadily increasing dq (resolution)? |
There was a problem hiding this comment.
Where do these numbers come from?
There was a problem hiding this comment.
Generally speaking, the numbers are a sensible range o be calculating reflectivity over. I am less sure about the linspace though as logspace is used in alot of real experiments. Though it doesn't really matter so much
There was a problem hiding this comment.
Realized that the provided q and dq are not used for anything in the SLD determination. However, they are required and are now changed to 1 as a dummy value and a code comment has been added.
| sample = _build_sample(self.storage, model_name) | ||
| probe = _get_probe( | ||
| q_array=np.linspace(0.001, 0.3, 10), | ||
| dq_array=np.linspace(0.001, 0.3, 10), # TODO why would we use a steadily increasing dq (resolution)? |
There was a problem hiding this comment.
Generally speaking, the numbers are a sensible range o be calculating reflectivity over. I am less sure about the linspace though as logspace is used in alot of real experiments. Though it doesn't really matter so much
Move functionality used more than 1 time to private functions:
_get_probe_get_polarized_probe_get_oversampling_get_sampleMade it possible to do a POC calculations with magnetism by setting
MAGNETISM=TrueRenamed constants to make it more clear what they represents.
Introduced new polarized probe that is needed for calculations with magnetism. The results obtained from the "ordinary" probe and the polarized probe are not identical. No work have been done yet to understand these differences.
Removed functionality that is no longer used:
'resolution': 'dq'anddqin refnxupdate_itemin refld