-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
199 make fitter a part of project #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your Project
class is generally good.
It owns various important objects - models, materials, calculator, fitter etc.
This will allow a very simple syntax for creating scripts, where the only module you import is Project
.
This is pretty much the same approach as we have with Job
in diffraction, so I envision merging these two at some point.
Additions to the Project class to expose functionality to APP.
Minor corrections to other code parts.
Renamed Fitter to MultiFitter because that is what it is
Change name of module paramter_utils.py to utils.py