Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

199 make fitter a part of project #200

Merged
merged 29 commits into from
Nov 15, 2024
Merged

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented Nov 13, 2024

Additions to the Project class to expose functionality to APP.

Minor corrections to other code parts.

Renamed Fitter to MultiFitter because that is what it is

Change name of module paramter_utils.py to utils.py

  • introduced new function to collect all unique names in the dicts produced by the sample and model

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added the feature New functionality or request label Nov 13, 2024
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your Project class is generally good.
It owns various important objects - models, materials, calculator, fitter etc.

This will allow a very simple syntax for creating scripts, where the only module you import is Project.
This is pretty much the same approach as we have with Job in diffraction, so I envision merging these two at some point.

src/easyreflectometry/project.py Outdated Show resolved Hide resolved
@andped10 andped10 merged commit e64c4b4 into develop Nov 15, 2024
32 checks passed
@andped10 andped10 deleted the 199-make-fitter-a-part-of-project branch November 15, 2024 12:25
@andped10 andped10 linked an issue Nov 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Fitter a part of Project
2 participants