Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin hatchling, gitignore #61

Merged
merged 1 commit into from
Dec 12, 2023
Merged

pin hatchling, gitignore #61

merged 1 commit into from
Dec 12, 2023

Conversation

andped10
Copy link
Collaborator

Latest version of hatchling caused error when doing:
pip install .

Pinned version to previous version that did not cause the issue

@andped10 andped10 requested a review from rozyczko December 12, 2023 10:19
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07e8ece) 97.86% compared to head (0267fb1) 97.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #61   +/-   ##
========================================
  Coverage    97.86%   97.86%           
========================================
  Files           41       41           
  Lines         3050     3050           
========================================
  Hits          2985     2985           
  Misses          65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue seen in pip install .
Similar change needs to be made in the app

@rozyczko rozyczko merged commit 5e423ca into develop Dec 12, 2023
24 checks passed
@rozyczko rozyczko deleted the pin_hatchling branch December 12, 2023 15:15
@rozyczko rozyczko restored the pin_hatchling branch December 12, 2023 15:15
@rozyczko rozyczko deleted the pin_hatchling branch December 12, 2023 15:15
@rozyczko rozyczko restored the pin_hatchling branch December 12, 2023 15:16
@rozyczko rozyczko deleted the pin_hatchling branch December 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants