Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Scipp (Dataset -> DataGroup) #66

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Latest Scipp (Dataset -> DataGroup) #66

merged 11 commits into from
Jan 11, 2024

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented Jan 10, 2024

Python 3.8 is no longer supported.

  • The latest version of scipp does not support python 3.8.

For the latest version of scipp to work we need to exchange the usage of Datasets to DataGroups.

  • The reason being that a Dataset now requires that dims (name and size) is equal for all the contained data.

A main difference between a dataset and a datagroup is that a datagroup doesn't have the same attributes. Instead the structure of the datagroup is more dictionary like.

Syntax has also been changed to only having one argument per line for method calls the extend over several lines.

Loops solely relying on the dictionary keys have been changed from key, value in dict.items(): to key in dict.keys():

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eab0d31) 97.86% compared to head (d89117e) 97.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #66   +/-   ##
========================================
  Coverage    97.86%   97.86%           
========================================
  Files           41       41           
  Lines         3050     3050           
========================================
  Hits          2985     2985           
  Misses          65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andped10 andped10 requested a review from rozyczko January 10, 2024 13:02
@andped10 andped10 changed the title Scipp Dataset to DataGroup Latest Scipp (Dataset -> DataGroup) Jan 10, 2024
@andped10 andped10 marked this pull request as ready for review January 10, 2024 13:12
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing DataArray with DataGroup is thorough.
The code is ready to be merged but please clear/reset monolayer.ipynb - it's got all the output cells and this makes the file unnecessarily large.

@andped10 andped10 merged commit e759eff into develop Jan 11, 2024
25 checks passed
@andped10 andped10 deleted the dataset-to-datagroup branch January 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants