-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Scipp (Dataset -> DataGroup) #66
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #66 +/- ##
========================================
Coverage 97.86% 97.86%
========================================
Files 41 41
Lines 3050 3050
========================================
Hits 2985 2985
Misses 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing DataArray with DataGroup is thorough.
The code is ready to be merged but please clear/reset monolayer.ipynb
- it's got all the output cells and this makes the file unnecessarily large.
Python 3.8 is no longer supported.
For the latest version of scipp to work we need to exchange the usage of Datasets to DataGroups.
dims
(name and size) is equal for all the contained data.A main difference between a dataset and a datagroup is that a datagroup doesn't have the same attributes. Instead the structure of the datagroup is more dictionary like.
Syntax has also been changed to only having one argument per line for method calls the extend over several lines.
Loops solely relying on the dictionary keys have been changed from
key, value in dict.items():
tokey in dict.keys():