Add the full state to step response (#171) #508
ci.yaml
on: push
Test Suite
2m 55s
Check code is formatted
12s
Lint and check
27s
Annotations
12 errors and 15 warnings
redundant pattern matching, consider using `is_ok()`:
src/tests/reachability/location_validation.rs#L46
error: redundant pattern matching, consider using `is_ok()`
--> src/tests/reachability/location_validation.rs:46:17
|
46 | assert!(matches!(
| _________________^
47 | | System::extract_state::get_state(&mock_state, &machine, &system),
48 | | Ok(_)
49 | | ));
| |_________^ help: try: `System::extract_state::get_state(&mock_state, &machine, &system).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
redundant pattern matching, consider using `is_err()`:
src/tests/reachability/location_validation.rs#L27
error: redundant pattern matching, consider using `is_err()`
--> src/tests/reachability/location_validation.rs:27:17
|
27 | assert!(matches!(
| _________________^
28 | | System::extract_state::get_state(&mock_state, &machine, &system),
29 | | Err(_)
30 | | ));
| |_________^ help: try: `System::extract_state::get_state(&mock_state, &machine, &system).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
redundant pattern matching, consider using `is_err()`:
src/tests/reachability/grammar.rs#L22
error: redundant pattern matching, consider using `is_err()`
--> src/tests/reachability/grammar.rs:22:17
|
22 | assert!(matches!(
| _________________^
23 | | parse_queries::parse_to_expression_tree(parser_input),
24 | | Err(_)
25 | | ));
| |_________^ help: try: `parse_queries::parse_to_expression_tree(parser_input).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
redundant pattern matching, consider using `is_ok()`:
src/tests/reachability/grammar.rs#L12
error: redundant pattern matching, consider using `is_ok()`
--> src/tests/reachability/grammar.rs:12:17
|
12 | assert!(matches!(
| _________________^
13 | | parse_queries::parse_to_expression_tree(parser_input),
14 | | Ok(_)
15 | | ));
| |_________^ help: try: `parse_queries::parse_to_expression_tree(parser_input).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
redundant pattern matching, consider using `is_ok()`:
src/tests/reachability/clock_variables.rs#L49
error: redundant pattern matching, consider using `is_ok()`
--> src/tests/reachability/clock_variables.rs:49:17
|
49 | assert!(matches!(
| _________________^
50 | | System::extract_state::get_state(&mock_state, &machine, &system),
51 | | Ok(_)
52 | | ));
| |_________^ help: try: `System::extract_state::get_state(&mock_state, &machine, &system).is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
|
redundant pattern matching, consider using `is_err()`:
src/tests/reachability/clock_variables.rs#L30
error: redundant pattern matching, consider using `is_err()`
--> src/tests/reachability/clock_variables.rs:30:17
|
30 | assert!(matches!(
| _________________^
31 | | System::extract_state::get_state(&mock_state, &machine, &system),
32 | | Err(_)
33 | | ));
| |_________^ help: try: `System::extract_state::get_state(&mock_state, &machine, &system).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_pattern_matching)]`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/TransitionSystems/transition_system.rs#L166
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/TransitionSystems/transition_system.rs:166:20
|
166 | .chain(right_child.component_names().into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right_child.component_names()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/iter/traits/iterator.rs:523:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
unnecessarily eager cloning of iterator items:
src/TransitionSystems/transition_id.rs#L105
error: unnecessarily eager cloning of iterator items
--> src/TransitionSystems/transition_id.rs:105:21
|
105 | / transition
106 | | .iter()
| | ________________________________-
107 | || .cloned()
108 | || .filter(|id| !matches!(id, TransitionID::None))
| ||_______________________________________________________________________^
| |_______________________________________________________________________|
| help: try: `.filter(|&id| !matches!(id, TransitionID::None)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `-D clippy::iter-overeager-cloned` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::iter_overeager_cloned)]`
|
this looks like a failed attempt at checking for the file extension:
src/DataReader/xml_parser.rs#L16
error: this looks like a failed attempt at checking for the file extension
--> src/DataReader/xml_parser.rs:16:5
|
16 | project_path.as_ref().ends_with(".xml")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_path.as_ref().extension().is_some_and(|ext| ext == "xml")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#path_ends_with_ext
= note: `-D clippy::path-ends-with-ext` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::path_ends_with_ext)]`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/TransitionSystems/transition_system.rs#L166
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/TransitionSystems/transition_system.rs:166:20
|
166 | .chain(right_child.component_names().into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right_child.component_names()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/iter/traits/iterator.rs:523:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
unnecessarily eager cloning of iterator items:
src/TransitionSystems/transition_id.rs#L105
error: unnecessarily eager cloning of iterator items
--> src/TransitionSystems/transition_id.rs:105:21
|
105 | / transition
106 | | .iter()
| | ________________________________-
107 | || .cloned()
108 | || .filter(|id| !matches!(id, TransitionID::None))
| ||_______________________________________________________________________^
| |_______________________________________________________________________|
| help: try: `.filter(|&id| !matches!(id, TransitionID::None)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `-D clippy::iter-overeager-cloned` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::iter_overeager_cloned)]`
|
this looks like a failed attempt at checking for the file extension:
src/DataReader/xml_parser.rs#L16
error: this looks like a failed attempt at checking for the file extension
--> src/DataReader/xml_parser.rs:16:5
|
16 | project_path.as_ref().ends_with(".xml")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `project_path.as_ref().extension().is_some_and(|ext| ext == "xml")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#path_ends_with_ext
= note: `-D clippy::path-ends-with-ext` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::path_ends_with_ext)]`
|
Check code is formatted
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Check code is formatted
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check code is formatted
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check code is formatted
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Check code is formatted
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint and check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint and check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint and check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint and check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Lint and check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|