Rust DBM Library: Use EDBM instead of UDBM everywhere #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n UDBM (and C/C++) entirely
… is set for that clock to 0 (the bound must be set otherwise the logic is wrong)
…not-refines checks to fail in test framwork
t-lohse
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to lose the dependency on UDBM and any C/C++ code entirely, improving build time, safety and runtime.
Improves the build process by allowing us to just use cargo, readme is updated.
The code should be safe everywhere now, as we use no unsafe blocks anywhere.
Without any other changes (e.g. this is still with no multithreading at all in any of the checks) the code is 7x faster in debug builds and 20x faster in release builds (on my machine, when running
cargo test/cargo test --release.Partially closes #111 until we want/need CDDs and allows us to work on #112
Also fixes all clippy warnings as a lot of new ones arrived with the changes so I just fixed 'em all.