Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust DBM Library: Use EDBM instead of UDBM everywhere #115

Merged
merged 10 commits into from
Sep 7, 2022
Merged

Rust DBM Library: Use EDBM instead of UDBM everywhere #115

merged 10 commits into from
Sep 7, 2022

Conversation

seblund
Copy link
Member

@seblund seblund commented Sep 1, 2022

Allows us to lose the dependency on UDBM and any C/C++ code entirely, improving build time, safety and runtime.

Improves the build process by allowing us to just use cargo, readme is updated.

The code should be safe everywhere now, as we use no unsafe blocks anywhere.

Without any other changes (e.g. this is still with no multithreading at all in any of the checks) the code is 7x faster in debug builds and 20x faster in release builds (on my machine, when running cargo test/cargo test --release.

Partially closes #111 until we want/need CDDs and allows us to work on #112

Also fixes all clippy warnings as a lot of new ones arrived with the changes so I just fixed 'em all.

@seblund seblund requested a review from t-lohse September 3, 2022 12:18
… is set for that clock to 0 (the bound must be set otherwise the logic is wrong)
@t-lohse t-lohse merged commit 1280524 into main Sep 7, 2022
@t-lohse t-lohse deleted the edbm branch September 7, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DBMs/CDDs and or Federations in Rust
2 participants