Feat/add impala #138
Merged
Feat/add impala #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any performance benchmarks with the IMPALA implementation? :) |
|
Hi, unfortunately not. I don't have the time to do large scale performance benchmarks. I wanted to do an ATARI-5 run which I still might do but comparing it against the true implementation of impala which is recurrent might be a little unfair. |
|
I understand. I was just wondering if you have seen it "train" at least |
|
oh, yes, i have seen it learn to solve all the simple env pool environments although i will say its worse than PPO in terms of sample efficiency and performance (which makes sense since it only updates once on the data). It also seemed to be more finnicky to hyperparams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add Impala sebulba system.
Why?
Useful to have a sebulba system that is not PPO.