Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLOUDDEV-594): fix client for working with l7policy #54

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

DamirZinatullin
Copy link
Collaborator

@DamirZinatullin DamirZinatullin commented Mar 25, 2024

https://tracker.yandex.ru/CLOUDDEV-594

  • Изменены типы атрибутов структур L7Policy и L7PolicyCreateRequest, для корректной передачи опциональных полей;
  • Создана фукнция GetLbL7PolicyFromName для возможности получения l7 политики по имени;
  • Написан 1 тест для функции GetLbL7PolicyFromName;
  • Добавлены общие ошибки ErrMultipleResourcesWithTheSameName и ErrResourceDoesntExist для возможности их перехватывания.

@DamirZinatullin DamirZinatullin force-pushed the feat/CLOUDDEV-594-l7policy branch from 87abab5 to e1ea341 Compare March 27, 2024 07:27
@DamirZinatullin DamirZinatullin changed the title fix(CLOUDDEV-594): fixed L7PolicyCreateRequest struct fix(CLOUDDEV-594): fix client for working with l7policy Apr 2, 2024
server := httptest.NewServer(mux)
defer server.Close()

lPolicyToFind := edgecloud.L7Policy{ID: testResourceID, Name: testName}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: l7PolicyToFind

@DamirZinatullin DamirZinatullin force-pushed the feat/CLOUDDEV-594-l7policy branch 2 times, most recently from fe3540e to fcbdbbf Compare April 12, 2024 06:13
…truct,

fixed L7Policy struct,
fixed L7PolicyCreateRequest struct,
added common errors,
added GetLbL7PolicyFromName func,
@DamirZinatullin DamirZinatullin force-pushed the feat/CLOUDDEV-594-l7policy branch from fcbdbbf to 293dc33 Compare April 12, 2024 06:15
@DamirZinatullin DamirZinatullin merged commit 293dc33 into master Apr 12, 2024
1 check passed
@DamirZinatullin DamirZinatullin deleted the feat/CLOUDDEV-594-l7policy branch June 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants