fix(CLOUDDEV-935): Fixed creating Subnet without Gateway ip #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakwilik
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Тут не так все просто, насколько помню, нужно уметь отправлять либо null либо пустую строку либо IP. Попробуй потестируй ручку через инсомнию с этими 3мя вариантами, поведение должно отличаться
string or nullThe default GW IPv4 address to advertise in DHCP routes in this subnet. Omit this field to let the cloud backend allocate it automatically. Set to null if no gateway must be advertised by the DHCP of this subnet (useful when attaching instances to multiple subnets in order to prevent default route conflicts)
DamirZinatullin
approved these changes
Jan 27, 2025
Leonid-St
approved these changes
Jan 27, 2025
dodgyturtle
force-pushed
the
fix/CLOUDDEV-935-subnet-without-gw
branch
from
4721ca5 to
95c60d6
Compare
dodgyturtle
force-pushed
the
fix/CLOUDDEV-935-subnet-without-gw
branch
from
95c60d6 to
9c7c4c2
Compare
DamirZinatullin
approved these changes
Jan 28, 2025
Yakwilik
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://tracker.yandex.ru/CLOUDDEV-935