Fixes to dumpData #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Apr 22, 2024
| name: string | ||
| } | ||
| interface TestDataFixture { | ||
| [partitionName: string]: TestData[] | ||
| } | ||
|
|
||
| describe('HashBase baselet', function () { | ||
| const memlet = makeMemlet(makeMemoryDisklet()) | ||
| let hashbaseDb: HashBase<TestData> |
There was a problem hiding this comment.
Note for the future, since this is out of scope for your changes:
Each test suite is supposed to be standalone. Mutating a single hashbaseDb from test-to-test means a failure earlier, like in the "insert" test, will also cause fake failures in the "query" test, because the state is wrong. Each test should create & initialize its own unique HashBase instance.
There was a problem hiding this comment.
Yeah, this is inherited. I can create a task for this, but which project should such a task go (backlog?)
This includes the test for `dumpData` with and without a partition argument.
We shouldn't be assuming that an empty partition will be used by the user, so we shouldn't initialize all CountBase instances with the empty partition in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none