Use the value from the LI.FI quote response data directly
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Aug 15, 2023
src/swap/defi/lifi.ts
Outdated
| @@ -312,7 +312,7 @@ export function makeLifiPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin { | |||
| spendTargets: [ | |||
| { | |||
| memo: approvalData, | |||
| nativeAmount: '0', | |||
| nativeAmount: mul(transactionRequest.value, '1'), | |||
There was a problem hiding this comment.
Yikes. This is the approval transaction and should never send actual funds. This could cause a loss of funds for the user.
| @@ -333,7 +333,7 @@ export function makeLifiPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin { | |||
| spendTargets: [ | |||
| { | |||
| memo: data, | |||
| nativeAmount: nativeAmount, | |||
| nativeAmount: mul(transactionRequest.value, '1'), | |||
There was a problem hiding this comment.
Why would this ever be different from nativeAmount. Lifi only supports from quotes, so if the user specifies that they only want to send 0.1234 of an asset, we can't send more than that.
paullinator
force-pushed
the
sam/lifi-fix
branch
from
8004b40
to
8a4efa7
Compare
samholmes
force-pushed
the
sam/lifi-fix
branch
from
8a4efa7
to
c84e51f
Compare
paullinator
approved these changes
Aug 15, 2023
The mainnet value must be sent as it is calculated by the LI.FI API because it includes mainnet amount needed to pay for bridge fees within the smart contract.
samholmes
force-pushed
the
sam/lifi-fix
branch
from
c84e51f
to
4ba5f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mainnet value must be sent as it is calculated by the LI.FI API because it includes mainnet amount needed to pay for bridge fees within the smart contract.
CHANGELOG
Dependencies
noneDescription
none