Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IP retrieval process from usermetric #773

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

tomqin93
Copy link
Contributor

@tomqin93 tomqin93 commented Dec 6, 2023

What this PR does / why we need it:
This PR removes IP retrieval process from usermetric to improve overall performance
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- remove IP retrieval process from usermetric

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fab8f89) 55.00% compared to head (e1c31ab) 55.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          23       23           
  Lines        2287     2287           
=======================================
  Hits         1258     1258           
  Misses        915      915           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93
Copy link
Contributor Author

tomqin93 commented Dec 6, 2023

some issue with goproxy server and Azure, will merge this PR

@tomqin93 tomqin93 merged commit d45f99e into main Dec 6, 2023
@tomqin93 tomqin93 deleted the usermetric-remove-getter branch December 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants