Skip to content

Update crud:doc() #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

riedde
Copy link

@riedde riedde commented Aug 23, 2024

crud:doc() can handle if the called ID doesn't exists, but the function fails if no ID is passed through. This occurs, e.g., if an element is read but not @key is available there. To avoid redundant conditionals for checking this, a conditional is implemented into crud:doc() by this PR.

@riedde riedde requested a review from peterstadler August 23, 2024 08:13
@riedde riedde self-assigned this Aug 23, 2024
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, many thanks!

@peterstadler peterstadler merged commit cc2f688 into Edirom:develop Aug 23, 2024
1 check passed
@peterstadler peterstadler added this to the Release 4.12 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants