Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to jump to a specific page #24

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

Diginaut
Copy link
Member

This pull request introduces a new feature that allows users to jump to a specific page number. The feature has been implemented in the footer section.

Changes:

  • Added a page input field in the footer to allow direct page navigation.
  • Implemented functionality to validate and process user input.

Issue Reference:
This PR addresses issue #22.

Testing:

  • Manually tested the feature with the default IIIF import.
  • Verified edge cases such as invalid inputs and out-of-range numbers.

@Diginaut Diginaut added the enhancement New feature or request label Feb 20, 2025
Copy link
Member

@DennisFriedl DennisFriedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs some work. Please don't merge yet.

Copy link
Member

@DennisFriedl DennisFriedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DennisFriedl DennisFriedl merged commit 979b308 into korngold Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants