Simple Logger #30
Simple Logger #30
Conversation
There was a problem hiding this comment.
Thanks for your contribution. I've made a couple of comments. Overall looks good and happy to merge after the comments are addressed. Look forward to more PRs in the future! Lots to do. Currently working on implementing pointers. Welcome any thoughts you have.
There was a problem hiding this comment.
Thanks for adding some additional commits. I will approve and merge this PR. Overall, it's very good and we really need this in Eucleia since there is an awful lot going on. I'm going to make another PR to address some of my new minor comments and to add the log level to our CLIParser so the user can specify the logging level
| { | ||
| public: | ||
| enum class Filter | ||
| { |
There was a problem hiding this comment.
I think the Filter is overkill. Personally, I would just use a second Level variable. Then you can compare the level of the message being passed in to the level of our Level variable since enum values are just increasing integers.
|
|
||
| void log(Level level, const char *file, unsigned int line, const char *func, std::string_view message); | ||
|
|
||
| inline void error(const char *file, unsigned int line, const char *func, std::string_view message) { log(Level::error, file, line, func, message); }; |
There was a problem hiding this comment.
It looks a little messy doesn't it? I think specifying the file, line, func was a mistake on my part. Also probably overkill on the log options: [debug, info, warning, error] are enough I think
| * @author Anand Doshi | ||
| * @date 2025-01-08 | ||
| * | ||
| * @copyright Copyright (c) 2025 |
There was a problem hiding this comment.
I've done some more thinking. I think the logger should be a singleton. We need an instance() public method and the constructor should be protected to prevent initialisation by the user. Then the info, error, ... methods become static methods calling instance().log(...)
@EdwardPalmer99 Enacted upon your TODO in utility.
Simple Logger class, inspired form Java's Logger.
Can log on five different levels, with three different filters.
Let me know what you think, and if you'd like to change the design.
I can also add tests if needed!