Skip to content

Comments

Enhancements to tiny OLEDs, OTA beautified #155

Open
trip5 wants to merge 12 commits intoEdzelf:mainfrom
trip5:esp32
Open

Enhancements to tiny OLEDs, OTA beautified #155
trip5 wants to merge 12 commits intoEdzelf:mainfrom
trip5:esp32

Conversation

@trip5
Copy link

@trip5 trip5 commented Oct 5, 2024

A quick summary of what's in this (as included in the main.cpp):

OLED 64x128 improvements: blank screen with backlight time (both available in prefs), character limit for small displays. Also: OTA beautified, fixed rotary timeout display, new esp-idf ADC (the new number is 12 for attenuation instead of 11).

I added a bunch of functions to help with small displays but I think they only apply to the tiny OLEDS. But they can be applied to other displays should the need arise.

I made a big change to the OTA too. It looks pretty good on my Tiny OLED. It didn't display any update information before at all. It was kind of a PITA to get it working the way it's supposed to.

@trip5
Copy link
Author

trip5 commented Nov 16, 2024

Out of curiosity, why not merge this?

I've merged your most recent changes... there shouldn't be any conflict.

@aly-fly
Copy link

aly-fly commented Dec 19, 2024

@Edzelf I am upvoting this PR, updates for the small OLED are very welcome.

@trip5
Copy link
Author

trip5 commented Dec 19, 2024

@aly-fly you can try it out on my fork if you like.

@aly-fly
Copy link

aly-fly commented Dec 25, 2024

@aly-fly you can try it out on my fork if you like.

Will do and report back.

Hint: It might be easier for the author to test and merge smaller updates, like separate OLED and separate OTA and not everything together. Just a guess. I know I would rater see it that way as an owner of a such popular repository.

@trip5
Copy link
Author

trip5 commented Dec 25, 2024

Yeah, I got a bit carried away... although part of the problem with that was... I actually worked on both bits of code simultaneously. There was no separating them once I had begun... and they do interact with each other... a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants