Handle arbitrary length StreamChunkPart #4630
Open
+31
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This changes
OpenAiClient.StreamChunk.text
andOpenAiClient.StreamChunk.asAiResponse
getters to respect arbitrary lengththis.parts
instead of only considering the first part.After patching this locally, I was able to use Google's Gemini models via their OpenAI compatibility API.
Areas to Review:
I'm not sure what is expected when there's multiple "Content" parts, all I know is that Gemini delivers one "Usage" and one "Content" part in the same chunk. For now I've
.join()
-ed all content parts into a single string.I'm not certain why the
asAiReponse
implementation produces an empty string of content for the case when no parts are present (versus just providing an empty parts array).effect/packages/ai/openai/src/OpenAiClient.ts
Lines 293 to 298 in 9a88bb9
I've preserved this behavior in case, though I imagine it could be removed.
Related
@effect/ai-openai
discards meaningful content with multipleStreamChunkPart
#4629