handle executable paths with spaces in CLI arguments, close #5845 #5853
+41
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Fixes executable path splitting when paths contain spaces (e.g.,
C:\Program Files\nodejs\node.exeon Windows or/usr/local/My Programs/nodeon Unix-like systems).Instead of using
executable.split(/\s+/)which breaks any path with spaces, we now extract runtime and script directly from the original args array usingArr.take(originalArgs, 2).Changes:
handleBuiltInOption()to acceptoriginalArgsparameterSetLogLevelcase to preserve paths with spaces when re-executing commandsShowWizardcase to preserve paths with spaces when running wizard-constructed commandsgetExecutableArgs()to extract runtime and script from original argsCliApp.test.tsTest plan:
npx tsx examples/minigit.ts --log-level info -c test=value clone https://github.com/test/repoRelated